@@ -1,3 +1,7 @@

+0.1709

+    - fixed named placeholder bug and added escape syntax

+0.1708

+    - improved execute method performance

 0.1707

     - I call :title named placeholder, stoping calling it parameter

     - removed some EXPERIMENTAL status

@@ -1,7 +1,7 @@

 package DBIx::Custom;

 use Object::Simple -base;

-our $VERSION = '0.1707';

+our $VERSION = '0.1709';

 use 5.008001;

 use Carp 'croak';

@@ -2169,6 +2169,12 @@ You can specify operator with named placeholder

     # Replaced

     select * from where title = ? and author like ?;

+Note that colons in time format such as 12:13:15 is exeption,

+it is not parsed as named placeholder.

+If you want to use colon generally, you must escape it by C<\\>

+

+    select * from where title = "aa\\:bb";

+

 The following opitons are available.

 =over 4

@@ -68,17 +68,19 @@ sub _placeholder_count {

 sub _parse_parameter {

     my ($self, $source) = @_;

-

+    

     # Get and replace parameters

     my $sql = $source || '';

     my $columns = [];

     my $c = $self->safety_character;

     # Parameter regex

-    my $re = qr/^(.*?):([$c\.]+)(?:\{(.*?)\})?(.*)/s;

+    $sql =~ s/([^:]):(\d+):([^:])/$1\\:$2\\:$3/g;

+    my $re = qr/(^|.*?[^\\]):([$c\.]+)(?:\{(.*?)\})?(.*)/s;

     while ($sql =~ /$re/g) {

         push @$columns, $2;

         $sql = defined $3 ? "$1$2 $3 ?$4" : "$1?$4";

     }

+    $sql =~ s/\\:/:/g;

     # Create query

     my $query = DBIx::Custom::Query->new(

@@ -88,7 +90,7 @@ sub _parse_parameter {

     return $query;

 }

-

+    

 # DEPRECATED!

 has tags => sub { {} };

@@ -211,7 +211,7 @@ is_deeply($rows, [{key1 => 1, key2 => 1, key3 => 1, key4 => 1, key5 => 5},

                   {key1 => 6, key2 => 7, key3 => 8, key4 => 9, key5 => 10}], "basic");

-test 'parameter';

+test 'Named placeholder';

 $dbi->execute($DROP_TABLE->{0});

 $dbi->execute($CREATE_TABLE->{1});

 $dbi->insert(table => 'table1', param => {key1 => 1, key2 => 2, key3 => 3, key4 => 4, key5 => 5});

@@ -241,6 +241,30 @@ $result = $dbi->execute(

 $rows = $result->all;

 is_deeply($rows, [{key1 => 1, key2 => 2, key3 => 3, key4 => 4, key5 => 5}]);

+$dbi->execute($DROP_TABLE->{0});

+$dbi->execute($CREATE_TABLE->{0});

+$dbi->insert(table => 'table1', param => {key1 => '2011-10-14 12:19:18', key2 => 2});

+$source = "select * from table1 where key1 = '2011-10-14 12:19:18' and key2 = :key2";

+$result = $dbi->execute(

+    $source,

+    param => {'key2' => 2},

+);

+

+$rows = $result->all;

+is_deeply($rows, [{key1 => '2011-10-14 12:19:18', key2 => 2}]);

+

+$dbi = DBIx::Custom->connect($NEW_ARGS->{0});

+$dbi->execute($CREATE_TABLE->{0});

+$dbi->insert(table => 'table1', param => {key1 => 'a:b c:d', key2 => 2});

+$source = "select * from table1 where key1 = 'a\\:b c\\:d' and key2 = :key2";

+$result = $dbi->execute(

+    $source,

+    param => {'key2' => 2},

+);

+$rows = $result->all;

+is_deeply($rows, [{key1 => 'a:b c:d', key2 => 2}]);

+

+

 test 'Error case';

 eval {DBIx::Custom->connect(dsn => 'dbi:SQLit')};

 ok($@, "connect error");

@@ -3436,7 +3460,7 @@ test 'DBIx::Custom header';

 }

-test 'parameter :name(operater) syntax';

+test 'Named placeholder :name(operater) syntax';

 $dbi->execute($DROP_TABLE->{0});

 $dbi->execute($CREATE_TABLE->{1});

 $dbi->insert(table => 'table1', param => {key1 => 1, key2 => 2, key3 => 3, key4 => 4, key5 => 5});