... | ... |
@@ -136,7 +136,7 @@ sub assign_clause { |
136 | 136 |
} |
137 | 137 |
} |
138 | 138 |
|
139 |
- # Create set tag |
|
139 |
+ # Assign clause (performance is important) |
|
140 | 140 |
join( |
141 | 141 |
', ', |
142 | 142 |
map { |
... | ... |
@@ -255,7 +255,7 @@ sub delete { |
255 | 255 |
$sql .= "from " . $self->_q($opt{table}) . " $w->{clause} "; |
256 | 256 |
|
257 | 257 |
# Execute query |
258 |
- return $self->execute($sql, $w->{param}, %opt); |
|
258 |
+ $self->execute($sql, $w->{param}, %opt); |
|
259 | 259 |
} |
260 | 260 |
|
261 | 261 |
sub delete_all { shift->delete(allow_delete_all => 1, @_) } |
... | ... |
@@ -568,7 +568,7 @@ sub insert { |
568 | 568 |
# Options |
569 | 569 |
my $param = @_ % 2 ? shift : undef; |
570 | 570 |
my %opt = @_; |
571 |
- warn "insert method param option is DEPRECATED" if $opt{param}; |
|
571 |
+ warn "insert method param option is DEPRECATED!" if $opt{param}; |
|
572 | 572 |
$param ||= delete $opt{param} || {}; |
573 | 573 |
|
574 | 574 |
# Timestamp |
... | ... |
@@ -592,7 +592,7 @@ sub insert { |
592 | 592 |
. $self->values_clause($param, {wrap => $opt{wrap}}) . " "; |
593 | 593 |
|
594 | 594 |
# Execute query |
595 |
- return $self->execute($sql, $param, %opt); |
|
595 |
+ $self->execute($sql, $param, %opt); |
|
596 | 596 |
} |
597 | 597 |
|
598 | 598 |
sub insert_timestamp { |
... | ... |
@@ -862,7 +862,7 @@ sub select { |
862 | 862 |
# Execute query |
863 | 863 |
my $result = $self->execute($sql, $w->{param}, %opt); |
864 | 864 |
|
865 |
- return $result; |
|
865 |
+ $result; |
|
866 | 866 |
} |
867 | 867 |
|
868 | 868 |
sub setup_model { |
... | ... |
@@ -1031,7 +1031,7 @@ sub update { |
1031 | 1031 |
$sql .= $self->_q($opt{table}) . " set $assign_clause $w->{clause} "; |
1032 | 1032 |
|
1033 | 1033 |
# Execute query |
1034 |
- return $self->execute($sql, $param, %opt); |
|
1034 |
+ $self->execute($sql, $param, %opt); |
|
1035 | 1035 |
} |
1036 | 1036 |
|
1037 | 1037 |
sub update_all { shift->update(allow_update_all => 1, @_) }; |
... | ... |
@@ -1102,7 +1102,7 @@ sub values_clause { |
1102 | 1102 |
} |
1103 | 1103 |
} |
1104 | 1104 |
|
1105 |
- # Assign clause(performance is important) |
|
1105 |
+ # values clause(performance is important) |
|
1106 | 1106 |
'(' . |
1107 | 1107 |
join( |
1108 | 1108 |
', ', |