@@ -1,6 +1,7 @@

 0.1631

   added experimental DBIx::Custom::Result end_filter method

   experimental extended select method's where option

+  fix select method empty where failed bug

 0.1630

   fix test bug

 0.1629

@@ -507,25 +507,36 @@ sub select {

     # Where clause

     my $param;

+    my $wexists;

     if (ref $where eq 'HASH' && keys %$where) {

         $param = $where;

-        $source .= 'where (';

-        foreach my $where_key (keys %$where) {

-            $source .= "{= $where_key} and ";

+        $wexists = keys %$where;

+        

+        if ($wexists) {

+            $source .= 'where (';

+            foreach my $where_key (keys %$where) {

+                $source .= "{= $where_key} and ";

+            }

+            $source =~ s/ and $//;

+            $source .= ') ';

         }

-        $source =~ s/ and $//;

-        $source .= ') ';

     }

     elsif (ref $where eq 'ARRAY') {

-        my$where_str = $where->[0] || '';

+        my $w = $where->[0] || '';

         $param = $where->[1];

-        $source .= "where ($where_str) ";

+        if (ref $w eq 'HASH') {

+            

+        }

+        else {

+            $wexists = $w =~ /\S/;

+            $source .= "where ($w) " if $wexists;

+        }

     }

     # Relation

     if ($relation) {

-        $source .= $where ? "and " : "where ";

+        $source .= $wexists ? "and " : "where ";

         foreach my $rkey (keys %$relation) {

             $source .= "$rkey = " . $relation->{$rkey} . " and ";

         }

@@ -786,3 +786,16 @@ $result->filter(key1 => sub { $_[0] * 2 }, key2 => sub { $_[0] * 4 });

 $result->end_filter(key1 => sub { $_[0] * 3 }, key2 => sub { $_[0] * 5 });

 $row = $result->fetch_hash_first;

 is_deeply($row, {key1 => 6, key2 => 40});

+

+

+test 'empty where select';

+$dbi = DBIx::Custom->connect($NEW_ARGS->{0});

+$dbi->execute($CREATE_TABLE->{0});

+$dbi->insert(table => 'table1', param => {key1 => 1, key2 => 2});

+$result = $dbi->select(table => 'table1', where => {});

+$row = $result->fetch_hash_first;

+is_deeply($row, {key1 => 1, key2 => 2});

+

+$result = $dbi->select(table => 'table1', where => [' ', {}]);

+$row = $result->fetch_hash_first;

+is_deeply($row, {key1 => 1, key2 => 2});